Bukkit

@Jalau

Should work fine on 1.7.8. Feel free to report back issues or create pull requests if you have solutions for certain problems.

@Synchlor

Please create a ticket for your issue and explain how this can be reproduced. Otherwise I can't help you / fix it.

@cindy_k

v1.18 is the latest file. There are no dev builds. Usually it only takes up to 2 days at max for the file to be approved so there should be no need to additionally setup and maintain external downloads in some kind.

Besides, if you subscribe to file uploads of this project (there is a button for that somewhere at the top of this page) you should get a notification whenever I upload a new file, together with a working direct link to that file.

@miniluigi008

1.) The main reason for it to break with each update is that it relies on manipulating the trading content for villagers. Bukkit has no API for that, therefore Shopkeepers has to manually use server-internal code, which is more likely to change between updates compared to things which are already provided by bukkit's API, which gets updated by the bukkit team on each minecraft update instead.
ProtocolLib (which is used to intercept and modify outgoing and incoming packets) wouldn't be suited for this, because currently we rely on many things and logic which is already handled by minecraft itself. We really only do slight manipulation to a temporary 'vitual' created villager's trade contents. The rest (puting the items into the correct slots, updating the trade window, react to player interactions like switching between trades, etc.) is still all handled by minecraft itself.
So with ProtocolLib we would have to manually recreate all this logic which minecraft is doing in the background ourself via intercepting and manipulating packets, and we probably would have to do updates on that as well, as the client and server's logic might change between updates as well. So it would be quite more complicated..

2.) Ehh, with 'out of space' your probably mean 'out of memory' / server crashing and not disk space (?): well, if you get an out-of-memory error / your server crashes there is nothing left we can do.. all code is stopped. While the server is running it should not delete the save file. The save file only gets deleted when it attemtps to save its current data. So for the file to get lost your server has to crash in right that moment.. I think. So otherwise only the not yet saved changes should get lost on a server crash.
However, the best, and most common solution for data backups, would be via some other, specialised utility/program which creates automatic backups of your system / minecraft server and plugin files. If you don't have full access to the system your minecraft server is running on, then you could either check if your hoster is providing you something for that, or you use one of those 'backup plugins' which can do this.

@MasterMithrandir

For removal of single shops there should be no need for commands. Instead it should be analyzed why this shop wasn't physically there in the world and improve on that.

@MasterMithrandir

Well, if the shop isn't physically there, then you might have to shutdown/disable the server/plugin before you attempt to manually modify the save file. Because when you reload shopkeepers it will save the previous loaded shopkeeper back to file, overwriting your changes.

@Nik912

The file is waiting for approval by bukkit staff. I just had to reupload it because I missed to change the version number in the previously uploaded file :(

v1.18 for MC 1.7.8+

• Updated to CB 1.7.8
• Fixed a serious item duping bug [Ticket 228]: double clicking in the bottom inventory while having the trading gui opened gets blocked now
• Now updating the players inventory shortly after a trade failed to reduce the chance for fake items popping up in the players inventory temporary.
• Now printing slightly more detailed debug message for failing trades, if debug mode is turned on.
• Removed unused stuff from the compatibility mode, which probably was the cause that this time the compatibility mode didn't work when you tried to use the old Shopkeepers version on 1.7.8 servers..
• Updated to use player uuids. Some notices on that:

• Make sure you run on some of the newest MC/Bukkit versions, because old versions might not support player account uuids correctly. I suggest that you use at least some 1.7.+ version.
• Make sure that your server runs in the correct online mode: player uuids don't match between online and offline mode. So if you switch your server's online mode the stored player uuids won't be 'working' anymore and your save file might get mixed with the different types of uuids..
• The uuids for owners of player shops get stored as soon as the player logs in. The playername gets used for display purposes and as identifier for the shop owner of those player shops for which we don't have an uuid yet.

Some possible caveats:

• If the trade for a written book fails players can sometimes still open and read the book if they close the shop and click the temporary fake book in their inventory fast enough. There is not much I can do about this..
• If you use the 'remove shopkeeper after certain time of inactivity of player' feature, then you might experience some server freezing when the plugin loads: to find out when the owner of a shop was online for the last time we use a method which might have to lookup a player's uuid or name via mojangs services. However, this is currently considered a minor 'issue' as those lookups can only happen once per plugin load (and reload), and the server probably also caches the results from those lookups, so the next plugin loads probably won't have to lookup those data again.
• If you have shops with items in it with attributes, those might disappear or crash players. I am not completly sure if this is an issue with shopkeepers or a general thing that the client can't cope with certain modified items and crashes then. I also experienced this only for the first time I tested the new 1.7.8 bukkit version, afterwards those items went lost somehow and stopped crashing the client. However I wasn't able yet to test the new shopkeepers version with items with custom attributes / edited nbt data, as I wasn't able yet to find some updated/working plugin which creates items with attributes..

I suggest you to backup your old save file, just in case

@catprowler

Nope. The trade menu is really only meant for item trades. A workaround would be to let players trade items, but also given them the possibility to exchange those items to your vault economy, with some other additional plugin.

@cindy_k

Normally Shopkeepers tries to remove the shopkeeper entities when chunks unload or the plugin/the server shuts down. However under some circumstances Shopkeepers isn't able to remove those entities properly and they get stored in the chunk data in your world.
This usually is only the case if you have some other plugin(s) running which unload chunks without calling an event for that / without letting Shopkeepers know (so that we can clean up those entities before they get saved into the chunk data).
This is no big issue as long as Shopkeepers is still running when the chunks get loaded again (we currently workaround this issue by search for old shop entities before spawning new ones).
But nevertheless you maybe might want to try to find out which of your plugins are silently unloading chunks so that they can 'fix' this. This might not be a big problem for those plugins themselves, but for other plugins if those are depending on the ChunkUnloadEvent for cleanup to happen..

Regarding those entities: you can safely kill them. Shopkeepers should respawn the needed shop entities as soon as it is running again.