Bukkit

@kymbl

Hi kymbl!

Shopkeepers is my favorite, too- I love physical economies. You can check out my survival server (when it's back online.....) or PotterWorld for an example.

Unfortunately, it's not SK's fault that Magic items get wiped when added to a shopkeeper. It's CraftBukkit's insistence on ruling over item data with an iron fist (CraftBukkit wipes the wand data any chance it gets)

That said, I have a custom CraftBukkit build that makes this work ... I probably shouldn't advertise that too much here, frankly, and on top of that my CI server is also down... I'm out of town right now and won't be able to get any of this working again for a week or so, unless some networking miracle occurs.

My custom CraftBukkit build is just the standard build plus this PR of mine:

https://github.com/Bukkit/Bukkit/pull/1064

Which allows for custom item data. Whether or not this gets accepted, custom item data is a vanilla feature in 1.8 (from what I understand), so I suspect that Bukkit will have to support it one way or the other eventually.

PM me if you'd like to try to get this working before then :)

<<reply 2284166="">>

That one task at 5% is a bit high, but it's not the login event. I'd be curious to know which task that is- all of the repeating tasks can be throttled in config.yml- there are 3 - one for engineering, one for rollback and one for "ticking" mages and wands.

I'll have to try out Spigot I guess :)

<<reply 2284125="">>

0.05%? Or am I reading that wrong? That's not going to be causing lag....

Magic loads player data asynchronously, I suspect it's not your issue, at least not with login lag spikes.

Magic generally spends all of it's time in the interact and itemheld events. That, and scheduled tasks.

On a side note, how did you get tasks to show up in timings?? Is that a spigot thing? I want it... I had to make the "/magic list tasks" command to deep dive into tasks, but this report looks really handy.

<<reply 2283922="">>

As far as I know! I didn't test it myself, but the person who reported the issue said it was resolved.

@ph1823

There are lots of other things you can sell, though.

Custom wand names, effects (wands can have potion bubbles on them of any color, or particle/sound FX)

You could also create your own cosmetic spells, not sure what they can do that doesn't violate EULA, but you could get creative I'm sure!

@ph1823

That would violate Mojang's EULA in almost all cases.

There are some spells like Flare that I would say are "cosmetic only" and OK to sell. But generally, no.

@ph1823

Ah, I got you!

Yes- there are a few ways. If you have Essentials, you can use shop signs like this:

[Buy]
1
spell: fling
$40

You can also use the dtlTraders plugin, and "/magic give fling" to get spell items to sell.

Shopkeepers (and many other plugins) can work with Magic items using a custom Craftbukkit or, most likely, in 1.8

@ph1823

Hm... I'm trying, but I'm afraid I don't understand :(

You can't "charge up" spells, that's a feature I'd like, but Minecraft's controls make it kind of difficult.

I'm not sure what you mean by the "element" either?

@minecraft_in_my_veins

If you can pastebin /logs/latest.log that would help a lot.

Knowing the CraftBukkit version you're running would be a place to start, though.

@minecraft_in_my_veins

That's not nearly enough information for me to help. What version of CraftBukkit are you running? Can you provide the full server logs with stack trace and error (that looks like uselessly truncated MCmyAdmin output or something)

This error shouldn't cause "massive server lag" since it's an event handler that only fires on click.