Bukkit

@bfathman6

Could take this idea a step farther:

• Specify any number of channels per world.
• Channels could be configured to send messages to any other channel in any other world.
• Channels can have configurable locality.
• Channels could have custom permission nodes tied to them, for join / speak / etc, allowing more control of who can access what for the channel.
• Join specified channels automatically upon entering a world.
• In game commands for joining / leaving / listing the channels of a world.
• Global channels, channels that can be accessed no matter what world.

Does any of the above sound worth it? I think this would be my approach to implementing what you want, as it allows for much more flexibility in how each world's chat channels are configured.

@Appljuze

Thanks for the stack trace.

First, let me point out something important, if you look at the first line of the exception:

Caused by: java.lang.NullPointerException

	at net.milkbowl.vault.chat.plugins.Chat_mChatSuite.getPlayerPrefix(Chat_mChatSuite.java:106)

You'll see that it's Vault that is causing the NullPointerException due to something with mChatSuite.

In any case, I've added some catch clauses around any of Vault's Chat class code. While this will mitigate any exceptions thrown by Vault's Chat class, this does mean that those fields that it tried to get, such as the group name, prefix and suffix, will not be populated by WorldChannels.

However, you did say that you wanted mChatSuite to handle your formatting, so it shouldn't be an issue for you.

I would say you ought to let the developers of Vault know of your exception, and give them a copy of the stack trace as well.

I'll be submitting the new version to BukkitDev. If its not available when you check the page, you'll also be able to grab it from the GitHub downloads page as well while it is awaiting approval here.

@Appljuze

I loaded the latest available version for mChatSuite, and it works with the default, auto-generated settings.

So, would you please post the entire stack trace of the error you are getting? Else, I can't do much.

@xDrapor

Ok, I just looked at McMMO's code. Their listener for chat events is on High. Mine is on Highest, so theirs executes first. For both the admin / party chats, they cancel the event, thus my plugin doesn't even touch the receivers at all for their chat stuff...

So, any "incompatability" with McMMO shouldn't be on my side, as my stuff doesn't execute for either the party or admin chat events because they receive and handle the event before I ever do.

Also, I've integrated the nobody message and the auto-observer permission node works now.

@xDrapor

Hey, sorry for the late reply.

Thanks for your work, it'd be pretty helpful if you were to send that over. Kinda tied up, but I'll try and work on it when I can.

@sgttarn

Yeah, definitely. That should go along with fixing the auto-observer node too... I'll get around to it when I can.

@xDrapor

Yeah, it sounds logical... but who knows, maybe it won't work as planned and end up being more complicated :P Won't know till I or you try to make the solution.

Also, yeah, lacking that message with the local chat feature... It was sorta rushed out so that the server that it was made for could use it immediately. So, I didn't add in that message... just got the basic proof of concept up and running for them. I'll make sure to add in the configurable message in later.

@sgttarn

That's correct, the formatter is completely optional. You would want to disable it in the global config as well as in each world config.

You should be able to still have it broadcasting to other worlds even with the formatter disabled. Can't look into it at the moment, but if it is still an issue later on, I'll look into it when I'm free.

@xDrapor

Yeah, its pretty simple. This plugin modifies who receives the message whenever a chat event occurs, based on the configuration for that world. The same applies for admin chat, in which it modifies who receives the message for the admin chat channel.

If you want, I can add in McMMO chat compatability for the next version. However, the update is going to be delayed until I finish moving... so I won't be able to do it until the weekend.

Or, if you want and if you have the time, you could make add in the compatibility and once its up you can make the pull request to have it added in to the official builds.

I think the solution would be rather simple:

• Have an optional listener that is enabled when McMMO is detected and if enabled in the config.
• On a McMMO chat event, add the sender's name to a set that can be viewed by the regular chat listener.
  • Set listener to monitor and only add to set if not cancelled.
• On the regular chat event, check to see if the player name is in the set. If so, stop early on and don't modify the event as we'd let McMMO handle it.

Obviously, the above is just a theory, but that's how I'd approach it and then test to make sure it works.

But hey, if you don't have the time, I'll make sure to add it in myself when I can. Just going sorta busy with moving between states and can't work on it until I'm properly situated.

Thanks for bringing it to my attention. I hope the above was helpful.