Bukkit

@ProjectHyrule

Everything seems to be working fine, I will be updating the current "tutorial" some time in the next week to detail the changes recently made (adding categories) and other than that, I will copy and paste from above:

Buying and Selling

Some notes on buying and selling:

Owners will always receive items from their shop for free (FREE) Owners can never sell items to their own shop. Items placed into a Traders buy screen will just be returned.

Thanks ;)

@ninjaangel

Currently to create a rental shop, you need the follow:

• ability to assign traits to an NPC
• be the owner of the NPC (if you want to control the rental)

then all you need to do is select the npc (with the stick) by Citizens 2 and the use the command:

/trait rentalshop

then click the NPC to open the rental admin conversation.

I will be eventually adding a command to create a rental, but till Ultratrader it self shows no more major errors I will likely only update as needed.

@ryanrmc

not knowing what version you updated from, or a paste of any errors/shop configs, I can't really say other that to remake them, if you want me to look into it I will need the following:

• A copy of a shop config file from you backups
• A copy of the shop config after the update
• startup log messages (particularly related to Ultratrader)
• version you updated from and version you updated too.

Thanks, and I will keep an eye out, but remember I still have the beta tag on for a reason ;)

@Chriszh

This might have been a random thing, or something else was done that you haven't listed, if you could reproduce this and capture it in video, maybe I can find it... my steps to try to reproduce this was...

1) adding and Enchanted Pickaxe 2) buying it back (for free) 3) clicking on Item Admin - using menu system to delete item (success)

1-2 same 3) Shift clicking item, event cancelled as expected 4) going into Item admin again, deleting item (success)

1-2 same 3) going into item admin again, exiting 4) shift clicking, event cancelled again as expected behavior. 5) deleting again from Item Admin menu system.

Only thing I can figure is that you were some how still in another conversation, having 2 conversations open while in a inventory screen does seem to crash a server, and all my conversations "should" be checking to make sure this doesn't happen, unless I missed one, which I will be looking for, another possibility I can think of (and not really saying it is) is that your server crashed while trying to enter the conversation from some other reason.

Unfortunately the conversation API isn't very forgiving, and suppresses all errors from displaying in console... please see if you can replicate this happening again.

@Chriszh

thats an odd one, I will check into it

@Chriszh

it is not a bug, but it is kinda odd how it looks... and I will be changing this next week.. (weekends are bad for me) but if you give the op/admin the permission of "trader.limits.maxshops.-1" they should be able to create unlimited shops..

As I don't really "check" for the permissions, this will require some additions and checks in my code, but for now just add high values to others (or 0 for costs, etc) and once I have the isOp checks in place I will let you know.

@Chriszh

Thanks again, and I am going to tell you about one before you get to tell me this time... clicking an item in inventory with another item in hand, will drop the item clicked (or used too ;)), you bug is fixed as well...

Also, limits are based on category for number of items allowed...and i will reset again the approval and replace with this download.

Jenkins will have new download...

Yet another dup fixed, there really shouldn't be many more (this is what BETA is for I guess)

@Rwin1234

Due to these errors I am forced to release this before I was ready, this was planned for a few more days at least. In order to fix this error I am going to release this now. There is one major breaking change. Limits.yml is no more, replaced with defaults located in config.yml

# Set the default limits of the server
# The old limits.yml is being phased out
defaults:
  trader:
    limits:
      category: 3
      levelcost:
        '1': 1000
        '2': 10000
        '3': 15000
        '4': 30000
      createshop: 1000
      createlevel: 1
      enableremote: false
      remoteitemcost: 500
      itemactivatecost: 10000
      maxshops: 1
      maxlevel: 1

Other changes:

• BOOK and QUILL removed from item view, it was rather useless anyways
• fixed the set price in the add item conversation
• changed some metrics settings (added hook so extensions can add graphs)
• fixed add category bug with dropping/adding categories and returning items.

Again I am sorry for this release, it should have been a few more days, but i feel that these need to be pushed now.. I will update Bukkit as soon as I get a good Jenkins Build, so for now, use Jenkins builds till this new version is approved.

@Rwin1234

trader.* doesn't exist would be why that didn't work, you have togive all the permissions

workaround for sell/buy prices is go into Item Admin (the book and quill that in the sell/buy area, not the item list or category areas. and manaully fix the prices there, they update, I failed to update the proper arguements when I refactored the set/buypriced on item add. Will fix and update shortly

@Rwin1234

If you are using .91, to add a category just drop an item into the category view, to edit categories, click on the book and quill and type in category, you will then be given the option to delete, edit, or exit, if you select either option you will be given the chance to select a category to edit/delete.

It is correct that there are no longer buyprices/sellprices, they have been consolidated into the "pricelist"