Trade

Table of Contents

Trade

Trade with other players!

How to install/use Trade:

Thanks to Skaranova for making this video!

Features:

Command less trading using right click to request players
No Spout required
Very easy to use trading screen
Customizable messages
Economy support Since version 0.3

Translations:

You can find translations on this page!

Commands:

Okay, there are a few commands. But they are completely optional.

/trade <playername> - Requests the named player.
/trade accept <playername> - Accepts request of named player.
/trade refuse <playername> - Refuses request of named player.
/trade ignore - Ignores all incoming requests.
/trade reload - Reloads the yamls.

Permissions:

See this page!

Configuration:

See this page!

Dependencies:

Optional:
- Vault if you want to use the economy trading screen

To do list:

Permission based layout system
Log/Rollback system

Reporting bugs:

If you found a bug in the plugin please be so kind to file a ticket here. It only takes little time to file one while helping me to keep things organised and fix these bugs quicker.

Known Issues:

Trade was rewritten after version 1.0. Version 1.0 is currently in BETA. It is not completely safe to say the BETA version does not contain any glitches at all but it is safer than any of the previous versions. If you want to use Trade use at least the BETA version"

Development builds:

Development builds of this project can be acquired at the provided continuous integration server. These builds have not been approved by the BukkitDev staff. Use them at your own risk.

https:josvthfoss.ci.cloudbees.com/job/Trade/

Source available on Github Build on Cloudbees!

If you like what I'm doing. Consider donating :) Please use the donate button in the top right.

Comments

_ForgeUser1511547
- Join Date: 10/26/2008
- Posts: 347
- Member Details
#242 _ForgeUser1511547

View User Profile

Send Message

Posted Nov 25, 2012
@lord0o

It's a good suggestion and since it is requested multiple times now it will probably make it into the plugin. However there is already a scam preventing system build in. Namely, when player B changes something while player A had already accepted the trade, the acceptation of player A is cancelled and he will recieve a message saying player B changed something. Maybe you are not noticing this what could mean that this system is not working properly. Could you please check if there is not a bug that disables the protection for you?

Rollback Post to Revision RollBack
_ForgeUser1034352
- Join Date: 8/13/2008
- Posts: 160
- Member Details
#241 _ForgeUser1034352

View User Profile

Send Message

Posted Nov 25, 2012
Sugestion:

Make a DOUBLE Confirmation event. like this: 1st step: putting items on the menu, 2nd step: each player accepts, leting them to see if the other player accepted the items. BLOCKING adding or removing items on the FIRST Accept event. and wait for the SECOND ACCEPT to see if everything is OK.

This is for preventing scams like player1: "here, take this sword1..." player2: "ok, take 64 diamonds...[ACCEPTED] player1: [changed sword1 for slimeball] player1: [ACCEPTED] player2: WTF DUDE**

Thanks for this excelent plugin!

Rollback Post to Revision RollBack
Forge_User_87615438
- Join Date: 7/4/2012
- Posts: 199
- Member Details
#240 Forge_User_87615438

View User Profile

Send Message

Posted Nov 25, 2012
This plugin is buggy, when both users trade one user can take items from another window, what the hell ;s?

Rollback Post to Revision RollBack
_ForgeUser6890456
- Join Date: 5/25/2011
- Posts: 22
- Member Details
#239 _ForgeUser6890456

View User Profile

Send Message

Posted Nov 25, 2012
all I get is you do not have permission to do that. Yet I am admin on a server I created?

Do I have to set permissions somewhere ? I am a bit of a noob atm so any help would be appreciated :-)

Last edited by _ForgeUser6890456: Nov 25, 2012

Rollback Post to Revision RollBack
_ForgeUser3908036
- Join Date: 1/25/2010
- Posts: 125
- Member Details
#238 _ForgeUser3908036

View User Profile

Send Message

Posted Nov 25, 2012
however i try i cant get the trade window to open. if i shift-rc a player, he cant accept and vice versa.

Rollback Post to Revision RollBack
Forge_User_87615438
- Join Date: 7/4/2012
- Posts: 199
- Member Details
#237 Forge_User_87615438

View User Profile

Send Message

Posted Nov 25, 2012
How to add money, from essentials eco?

Rollback Post to Revision RollBack
_ForgeUser8075891
- Join Date: 12/14/2011
- Posts: 2,145
- Member Details
#236 _ForgeUser8075891

View User Profile

Send Message

Posted Nov 24, 2012
Thanks! :)

Last edited by _ForgeUser8075891: Nov 24, 2012

Rollback Post to Revision RollBack
_ForgeUser7478387
- Join Date: 9/1/2011
- Posts: 98
- Member Details
#235 _ForgeUser7478387

View User Profile

Send Message

Posted Nov 24, 2012
Excellent plugin!

Rollback Post to Revision RollBack
Forge_User_04737119
- Join Date: 8/27/2011
- Posts: 5
- Member Details
#234 Forge_User_04737119

View User Profile

Send Message

Posted Nov 24, 2012
@josvth

And I even more like to hear responses like that. Please put that info into your "Features" list, because I was searching every page of this plugin and I couldn't find it. And I wasn't able to test that plugin because my server's world was generating.

Rollback Post to Revision RollBack
_ForgeUser1511547
- Join Date: 10/26/2008
- Posts: 347
- Member Details
#233 _ForgeUser1511547

View User Profile

Send Message

Posted Nov 23, 2012
@ZebrasBlak

I like when someone make a comment like this and I can say it's already in! Just look it up in the config. Just look at the request restrictions. It is called max-distance.

Rollback Post to Revision RollBack
Forge_User_04737119
- Join Date: 8/27/2011
- Posts: 5
- Member Details
#232 Forge_User_04737119

View User Profile

Send Message

Posted Nov 23, 2012
The only thing you must implement is the range between two players when they are allowed to trade and no. So there won't be trades between oceans.

Rollback Post to Revision RollBack
_ForgeUser1511547
- Join Date: 10/26/2008
- Posts: 347
- Member Details
#231 _ForgeUser1511547

View User Profile

Send Message

Posted Nov 21, 2012
@cembry90

Your problem is fixed in the next build. I'm just trying to find the reason for Ottocraft's problems. And then I'll release it.

Last edited by _ForgeUser1511547: Nov 21, 2012

Rollback Post to Revision RollBack
_ForgeUser1511547
- Join Date: 10/26/2008
- Posts: 347
- Member Details
#230 _ForgeUser1511547

View User Profile

Send Message

Posted Nov 21, 2012
@ottocraft

Could you explain your problems a bit more? And could you please file a ticket http:dev.bukkit.org/server-mods/trade/create-ticket/ it would help me keep things organised.

Rollback Post to Revision RollBack
_ForgeUser9759544
- Join Date: 10/7/2012
- Posts: 69
- Member Details
#229 _ForgeUser9759544

View User Profile

Send Message

Posted Nov 19, 2012
removed money is not coming back !!!

Rollback Post to Revision RollBack

_ForgeUser3962498

Join Date: 2/2/2010
Posts: 32
Member Details

#227 Posted Nov 18, 2012

@freakyy85

I get a similar error when clicking outside of the window (in the dark gray area):

13:34:18 [SEVERE] Could not pass event InventoryClickEvent to Trade v0.5
org.bukkit.event.EventException
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:341)
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62)
        at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:477)
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:462)
        at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:1147)
        at net.minecraft.server.Packet102WindowClick.handle(SourceFile:31)
        at net.minecraft.server.NetworkManager.b(NetworkManager.java:290)
        at net.minecraft.server.NetServerHandler.d(NetServerHandler.java:112)
        at net.minecraft.server.ServerConnection.b(SourceFile:39)
        at net.minecraft.server.DedicatedServerConnection.b(SourceFile:30)
        at net.minecraft.server.MinecraftServer.r(MinecraftServer.java:595)
        at net.minecraft.server.DedicatedServer.r(DedicatedServer.java:222)
        at net.minecraft.server.MinecraftServer.q(MinecraftServer.java:493)
        at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:426)
        at net.minecraft.server.ThreadServerApplication.run(SourceFile:856)
Caused by: java.lang.ArrayIndexOutOfBoundsException: -1
        at java.util.ArrayList.elementData(Unknown Source)
        at java.util.ArrayList.get(Unknown Source)
        at net.minecraft.server.Container.getSlot(Container.java:96)
        at org.bukkit.craftbukkit.inventory.CraftInventoryView.getItem(CraftInventoryView.java:65)
        at org.bukkit.event.inventory.InventoryClickEvent.getCurrentItem(InventoryClickEvent.java:52)
        at me.josvth.trade.listeners.TradeListener.onTradeInventoryClick(TradeListener.java:77)
        at sun.reflect.GeneratedMethodAccessor211.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
        at java.lang.reflect.Method.invoke(Unknown Source)
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:339)
        ... 14 more

Also when a player closes the trade window using escape, they don't get their item back.

Last edited by _ForgeUser3962498: Nov 18, 2012

_ForgeUser3908036
- Join Date: 1/25/2010
- Posts: 125
- Member Details
#226 _ForgeUser3908036

View User Profile

Send Message

Posted Nov 18, 2012
i also get this error: http://pastie.org/private/kof0hk8skiyvfclbskrhow

Rollback Post to Revision RollBack
_ForgeUser3908036
- Join Date: 1/25/2010
- Posts: 125
- Member Details
#225 _ForgeUser3908036

View User Profile

Send Message

Posted Nov 18, 2012
ok that error doesnt show up anymore. another problem now. when shift-rightclicking a player, it says "request to trade with player..." if then player shift-rigthclicks me, i get the message "player requests to trade with you" but no trade window opens. this doenst happen after the timeout but within the usual timeframe where player should be able to answer my trade request.

Rollback Post to Revision RollBack
_ForgeUser1511547
- Join Date: 10/26/2008
- Posts: 347
- Member Details
#224 _ForgeUser1511547

View User Profile

Send Message

Posted Nov 18, 2012
@never2nv

Hello!

You can already disable right-click and shift-right-click requests in the config. Just set right-click and shift-right-click false under request restrictions.

Like this:

request:
restrictions:
right-click: false
shift-right-click: false

Last edited by _ForgeUser1511547: Nov 18, 2012

Rollback Post to Revision RollBack
_ForgeUser1511547
- Join Date: 10/26/2008
- Posts: 347
- Member Details
#223 _ForgeUser1511547

View User Profile

Send Message

Posted Nov 18, 2012
@freakyy85

Could you check if this version fixes your problems?

Rollback Post to Revision RollBack
_ForgeUser3908036
- Join Date: 1/25/2010
- Posts: 125
- Member Details
#222 _ForgeUser3908036

View User Profile

Send Message

Posted Nov 18, 2012
also enabling shift-rightclick and disabling just rightclick in the config still gives me rightclick.

Rollback Post to Revision RollBack
To post a comment, please login or register a new account.

Project ID

39048
Created

Apr 24, 2012
Last Released File

Jan 24, 2013
Total Downloads

87,023
License

GNU General Public License ver...

Bukkit

Trade

Bukkit Plugins

Trade

Table of Contents

Trade

Trade with other players!

How to install/use Trade:

Features:

Translations:

Commands:

Permissions:

Configuration:

Dependencies:

To do list:

Reporting bugs:

Known Issues:

Development builds:

Comments

About This Project

Categories

Members

Recent Files

Bukkit