Bukkit

v1.57-ALPHA for MC 1.6.2, 1.7.x, 1.8.x

This version is marked as ALPHA, because it is including a bunch of internal changes which weren't properly tested yet and which might especially affect trading and saving of shopkeeper data. This version is currently only meant for testing purposes and finding potential issues.

Please create a backup of your shopkeeper save.yml file before using this version.
You might especially want to check if all shopkeeper trades get properly loaded and saved, and if the setup of shopkeepers, trading and item removal and disposal in/from player-shop-chests is working properly.
If you discover any issues please let me know by creating tickets for those.

• Internal change: Removed own trading-recipe-finding code, and instead getting the reciped used in the current trade from minecraft directly. With this it should be guaranteed that we really get the same recipe as minecraft is actually using. Also we have less work for keeping it updated.
• Internal change: The code which adds and removes an item stack to/from a chest was changed. Adding an item stack should now try to first fill up existing item stacks before starting to create new ones.
• Fixed: The trading and buying player-shopkeepers are now adding those items to the chest, which were actually used by the trading player. Depending on item comparison of minecraft and shopkeeper settings those don't have to perfectly match the required items from the used recipe, but are still accepted.
• Fixed: The owner name for player shopkeepers was initially (on creation) getting stored in lower case for some reason in the past. This probably caused issues at some places when we were comparing the owner name to the name of a certain player, for example when using the remove command.
• Tiny change/fix (not sure if this was actually an issue): Skipping npc players now when doing some initialization with the online player when the plugin gets enabled.

@tpsy12021

Please don't post error stack traces in the comment section, but instead create a ticket and attach them there, or upload them somewhere else, such as pastbin.com and only leave the link to it here. They are quite spammy.

Regarding the issue: Please try without AttributeHider. It might be that the issues lies there and is only triggered by shopkeeper when a window is opened.

v1.56-ALPHA for MC 1.6.2, 1.7.x, 1.8.x

This version is marked as ALPHA, because it is including a bunch of internal changes which weren't properly tested yet and which might especially affect trading and saving of shopkeeper data. This version is currently only meant for testing purposes and finding potential issues.

Please create a backup of your shopkeeper save.yml file before using this version.
You might especially want to check if all shopkeeper trades get properly loaded and saved, and if the setup of shopkeepers, trading and item removal and disposal in/from player-shop-chests is working properly.
If you discover any issues please let me know by creating tickets for those.

• Removed custom item comparison, which was used in the past to only allow trades if the required and the offered items perfectly match, excluding internal attribute uuids. This is now useless, because of changes in minecraft's 1.8.x trading logic.
  Unfortunately detailed debug messages, telling exactly why certain items are not similar, are no longer possible with this change.
• Updated to minecraft's new 1.8.x trading logic:
  Previously minecraft did unlock a trade if the type of the offered items matches the required item. Now in MC 1.8.x if a trade requires an item with custom data, such as custom name, lore or attributes, minecraft only unlocks the trade if the offered item perfectly matches the required one (all the item's internal data and attributes have to be the same).
  If the required item has no special data, then any item of the same type, even items with special data, can be used for this trade.
  Also, minecraft sometimes unlocks a non-selected trade, if the required items of a different trade is matching the ones which are currently inserted.

Shopkeepers is now trying to allow most of those trades as well. So if a trade requires an item without special data, every item of that type is accepted. If an item with special data is required, only perfectly matching items are accepted.

• Added setting use-strict-item-comparison setting, which defaults to true. When this setting is active trading behavior is nearly the same as before: An additional and more strict item comparison is performed before a trade is allowed, which makes sure that the items offered perfectly match those of the used recipe. So even if the required item has no special data, only items of the same type which as well don't have special data are accepted. Otherwise the trade gets blocked.
  This setting's default is currently set to true, to prevent potential issues with already setup shops, which expect the old/current trading behavior. Also servers running on MC versions below 1.8.x might depend on this setting to be active.
  For servers using the latest server versions I recommend disabling this setting, so that the trading logic better matches the one of minecraft.

• Changed: Resetting the player's selected chest after successfully creating a player shopkeeper. This seems to be more intuitive.
• Fixed: the default shop-created message for the buying shopkeeper did say that one of each item which is being 'sold' has to be entered into the chest. Instead it was meant to say 'one of each items being bought'.

@sleite

The underlying shopkeeper should get removed (from the save file) once you delete the citizens npc which holds the related shopkeepers trait, assuming the shopkeepers plugin is running at that moment.

Non-citizens shopkeeper can only be removed via the shopkeeper edit menu.

@MineCraftMyph

As I said below: that is not a bug, but intended behavior.

@MineCraftMyph

Please create tickets for each of your feature requests. I can look into them once I have some more time.
Regarding walking shopkeepers: that's not something I would currently attempt to add, because of the way the plugin currently stores, loads and unloads the entities.
If you want that maybe take a look at the experimental citizens type shopkeeper. Citizens handles its entities completely differently and thus has more control over what can easily be done with those entities without causing problems. Though it also requires an higher amount of work when updating between versions, that's why shopkeepers is currently doing it differently.

Regarding your issue: this behavior is intentional. The items required and the items offered have to perfectly match in order for the trade to be available. For the future there could maybe be settings with which you can change this kind of behavior to your needs, however currently there isn't.

@MineCraftMyph

It is awaiting approval of the dbo staff. It iwll be visible to you once it got approved.

Alternatively, you can subscribe for file updates on this project, to get a notification and a link everytime I upload a new file.

v1.55 for MC 1.6.2, 1.7.x, 1.8.x

• Fixed: Actually include the update for 1.8.4.

@IamYourDoodie @Bodyash

I made a small mistake in the last update(s) which caused that the code for 1.8.4-compatibility wasn't included in the plugin jar. Sorry for that. Try again with v1.55.