Bukkit

@ccman972

Sounds like it's working for you now? Good to go?

Regarding "*" permissions, they don't work like they "used to" back in the Perm2 days. They were explicitly "broken" (from an admin POV) in superperms, read the top paragraph at this link:

http://dev.bukkit.org/server-mods/permbukkit/pages/faq/

This means a plugin author must explicitly provide "*" nodes in order to simulate the old behavior. So I have defined "hsp.*" for example, but I've not defined "hsp.command.spawn.*". What you're trying to do is logical, unfortunately Superperms didn't agree. You can read the HSP plugin.yml to see what permission sets have been explicitly defined for use.

If you're using one of the defined nodes such as "hsp.full" and it's not working (as verified with /permcheck), then all I can say is, it is implemented correctly (HSP's usage of the nodes and the permission checks), so there is a breakdown with your permission system - and there are known issues with this and certain combination of permission systems (PEX is notorious for issues - see mbaxter's excellent write-up). This is why I provide the /permcheck command for troubleshooting.

I'll download your ZIP file and poke around to see if anything obvious turns up or if I can reproduce the issue. At the very least if I can find the specific set of circumstances/plugins that trigger the "hsp.full" not working as expected, I can document it in the FAQ for others to beware of.

At this point, based on your most recent edits, I assume you've solved the issue and are up and running - please let me know if otherwise.

@diannetea

More details please? Was it working in 1.7.1 or were you running 1.6.3 previously? Do you see any errors on startup? Perhaps something like: "No command classes found, HSP will not be able to register commands!"

Or are other HSP commands working and just not /home? Does "/hsphome" work? Does "/home" do anything at all?

If you can install Plugman and run a "/plugman vlist" for me as well as the output of "/version", that would show me Bukkit and all plugins and versions and I can try to reproduce the issue. Configurations of other plugins that have /home commands might be a next step as well. Feel free to open a ticket on the issue and we can track the details there.

@ccman972

Care to share your config.yml? (why post a problem you want help with and make me guess at the relevant facts?) From your description I'm guessing it looks something like this:

permissions:
  - pex
core:
  # this is ONLY used when "ops" is used in the "permissions"
  # section above.
  # In that case, any permissions listed here are given to
  # everyone by default (ops always have full permissions)
  defaultPermissions:
    - hsp.command.home.use 
    - hsp.command.spawn.use 
    - hsp.command.sethome.use

I left the comments in place, copied straight from the config_defaults.yml (available online).

The comments hint at what may be the problem: core.defaultPermissions is only used if you are using "ops" permissions, but you stated you aren't. core.defaultPermissions is a crutch for those people who don't want to use a permission system but still want some control over the defaults. It is disabled if you use anything other than "ops", because that means you have a real permission system you should be using instead.

Have you read the FAQ?

http://dev.bukkit.org/server-mods/homespawnplus/pages/faq/#w-i-installed-hsp-but-users-cant-use-home-sethome-or

It describes using the command "/pc hsp.command.home theplayer" (try it from the console if you can't figure out permissions to get access to /permcheck). Have you tried that? Do the players have the access you intend?

"also i have a server to run, otherwise im going to change to Essentials spawn"

Pardon? You seem to be indicating that you're a busy man with a server to run and threatening if I don't help you you'll switch to Essentials? This is your 4th time posting for help and this is the most information you've provided; you've never indicated you've read the FAQ or tried the steps there.

Thousands of people have downloaded and used HSP just fine, with PEX and other permission systems. So your problem, as best I can tell at this point, is unique to your situation. If you want help, you'll have to do some work yourself, pastebin config files, show that you've walked through the FAQ and confirmed the users do in fact have the permissions you intend as shown by the /permcheck command and perhaps show what other plugins you are using (always possible another plugin is stealing /home, /sethome, etc. Have you looked into command usurping?)

In general, the quality of support you receive will be directly related to the amount of information you gather & share about your problem and the amount of reading you do of the online docs. That will be true of any plugin you use.

If you want to use Essentials spawn and find that it meets your needs, then by all means, don't let me stop you.

@ThisUsernameIsMine

Can you open a ticket for the backslash issue? So I don't forget about it. I'll fix it next time I do a release.

Not sure on the home/spawn not found thing, it suspect it is case sensitive.

And thanks for the update on 1.7.2, glad it's working as expected.

@Apple_columb

My Avatar is Ichigo, as you've identified. I don't know when I last changed it.

Glad you like the spawnLastLocation, it's a new 1.7 feature so I wasn't sure if anyone was even using it yet. In that case, yes, the overhead on playerTeleport is required. I use mysql on my server and as you can see from my pastebin, the average call time is 0.50 milliseconds (< 1/1000 of a second).

@ThisUsernameIsMine

Thanks for the early report. Turns out I somehow uploaded the wrong file, the version uploaded was a really old v1.5.3 version. No idea how that happened, but I've deleted the wrong file and uploaded the correct v1.7.2. Will have to be re-approved by Bukkit admins before it syndicates, but here's a direct link for now: http://dev.bukkit.org/server-mods/homespawnplus/files/41-v1-7-2/

I've downloaded the file and tested it locally and it works for me, but I'd appreciate if you let me know if it works OK for you also.

@ThisUsernameIsMine

Hmm. It shouldn't have changed those. Did you restart or just /reload? The command system changed in 1.7.2 and due to the way Bukkit reloads, the old JAR is still referenced as the new one is loading, which causes command issues in 1.7.2. If you have restarted and are still seeing these issues, then it's a new bug to me. I'll try to reproduce locally.

@Apple_columb

Well that info certainly is helpful. I see you are running WorldGuard. On my server, at least, WorldGuard is far heavier of a plugin.

With this context, back to your original question: I can now see the event causing what you asked about is PlayerTeleportEvent, which is what I suggested. What HSP database are you using? If you don't ever want to use the "spawnLastLocation" strategy, it wouldn't be hard to add a config option to turn the storing of last location off, then you can disable it if not in use. I doubt it will solve your lag problems, but at least you can put it behind you and move on to whatever the next thing is.

@Apple_columb

Ah, some information and an actual question! Your second post is much better framed than your first; you might consider starting with well-formed questions in the future, it increases your chance of getting a useful response. TL;DR at end if you just want a summary.

I recently did some performance tuning on my own server, using Bukkit's built-in profiling mechanism. So I have some numbers handy from that to compare to: http://pastebin.com/x6g3X7UH

So HSP is not the heavy hitter on my server. HSP has a lot of functionality so it's certainly not a "lightweight" plugin, but at the same time I work hard to keep performance tuned so that HSP is not a factor for lag. In fact, it even has built-in monitoring and it will alert you in the logs if it finds some events are taking too long (for example, perhaps someone is using a long strategy chain that takes longer than they expected to run).

I don't know what other plugins you are running, so I have no comparison for how HSP is in your particular environment, but as you can see here it's certainly not my heaviest hitter.

That said, as a result of looking at the latest timings, I did notice over half of the time HSP is spending in this dump is in "PlayerMoveEvent", which shouldn't even be registered on my server. HSP only registers it if you have WorldGuard running, and even then it's only supposed to register it if you use one of the WorldGuard-specific strategies that requires the event. I don't, so I've fixed that now. It's not a huge deal in any case, only 732 ms (<1 full second) on my server in over 6 hours of timings, but I do take performance seriously so next release this event won't be registered unless you're using strategies that require it. Prior to this PlayerMoveEvent for WorldGuard, HSP averages for me in the 320ms (total) range.

Since WorldGuard is far heavier weight than HSP (as shown in my printout), I'll assume you're not running WorldGuard, so PlayerMoveEvent isn't being hooked on your server. That leaves the next most likely heaviest hitters to be PlayerTeleportEvent and EntityDamageEvent. The latter is only hooked if you have enabled warmups (for damage monitoring). The "heft" in PlayerTeleportEvent is because HSP 1.7 now tracks the last location of a person when they crossWorld teleport, so that has a database write (fast, but some small overhead as seen). I can look into turning this off via a config flag for those who don't want to use this feature.

HSP is one of the few plugins I know of that goes out of its way to NOT register events if not needed, based on admin config settings. For example, not registering PlayerMove if you're not using WorldGuard (the only case where it's required) and not registering EntityDamageEvent if you're not using warmups (the only case it's required).

I take performance seriously, so if you're seeing an issue other than "HSP is the heaviest plugin I've chosen to run on my server", then there's not much I can offer other than: is it causing you any issues; are you seeing lag? And if the answer is yes, then share your configs and I will tell you what you can turn off to minimize the HSP footprint. Also if HSP notices any long-running events, it will print them into your system log with the string "**LONG", so you can look for that to see if HSP is noticing any lag-inducing behaviors from it's own events.

TL;DR HSP is well-tuned for performance, it's not the worst offender out of a list of common plugins people use and shouldn't be causing you lag issues. If you don't like that HSP necessarily involves some small overhead due to the wealth of features it provides, then you might want to run something else. If you DO notice an issue with HSP causing lag, I take that seriously so provide the details, your configs, logs, etc and I will look into it.