Bukkit

@cnaude

Also the checkSign method has this issue as well.

Hello, i own a spigot server and I really love this plugin. However it keeps crashing or getting OOM errors. So i looked through my crash reports and through your source and ive found the problem that could be causing the out of memory errors. Take a look at this method that you have here:

private boolean checkFrame(Block block, BlockFace face, Player player) {
        // Go through the blocks next to the clicked block and check if are signs on the end.
        
        for (int i = 1; true; i++) {
            Block relative = block.getRelative(face, i);
            int x = relative.getLocation().getBlockX();
            int y = relative.getLocation().getBlockY();
            int z = relative.getLocation().getBlockZ();
            if (!isValidChair(relative) || (block.getState().getData() instanceof Stairs && ((Stairs) relative.getState().getData()).getDescendingDirection() != ((Stairs) block.getState().getData()).getDescendingDirection())) {
                if (relative.getType().equals(Material.AIR)) {
                    for (Entity e : player.getNearbyEntities(plugin.distance, plugin.distance, plugin.distance)) {
                        if (e instanceof ItemFrame && plugin.validSigns.contains(Material.ITEM_FRAME)) {
                            int x2 = e.getLocation().getBlockX();
                            int y2 = e.getLocation().getBlockY();
                            int z2 = e.getLocation().getBlockZ();
                            if (x == x2 && y == y2 && z == z2) {
                                return true;
                            }
                        }
                    }
                } else {
                    return false;
                }
            }
        }
    }

The for loop can continute without end unless returned. It seems that either this if statement is never true:

if (!isValidChair(relative) || (block.getState().getData() instanceof Stairs && ((Stairs) relative.getState().getData()).getDescendingDirection() != ((Stairs) block.getState().getData()).getDescendingDirection()))

or its true however it always goes into this loop and does not return due to the locations not being the same.

for (Entity e : player.getNearbyEntities(plugin.distance, plugin.distance, plugin.distance)) {
                        if (e instanceof ItemFrame && plugin.validSigns.contains(Material.ITEM_FRAME)) {
                            int x2 = e.getLocation().getBlockX();
                            int y2 = e.getLocation().getBlockY();
                            int z2 = e.getLocation().getBlockZ();
                            if (x == x2 && y == y2 && z == z2) {
                                return true;
                            }
                        }
                    }

In my opinion you should never have an unlimited loop like this. If something goes wrong, and a false positive runs this method it will not end and that can easily cause an OOM error. Im pretty sure this is the problem since when it runs out of Memory the main server thread is running %100 non-stop till the server is shutdown manually but killing the process.

Ive found all this from looking at this old crash report: http://pastebin.com/itL2iLdk

Great plugin! You should add the ability to ride animals that you normally couldn't. Like PetCreeper.

Same thing is happening to me.. Does not generate a config on startup with newest version :/

Best plugin on bukkit :p

can you pls make it compatible with Smart moving mod? If I use the mod, Characters sit in mid air.(Like one block above the chair) If I change the config, the users without smart moving mod sink down into the ground.

I'll Be waiting for an update or a comment with an helpful advice

@pnndzwdz

[WARNING] [CraftBook] Chairs require ProtocolLib! They will not function without it! ? Download ProcoLib bukkit.

I have a problem because chairs plugin is loading with server: 2013-04-11 11:03:34 [INFO] [Chairs] Loading Chairs v2.0.2 , but it doesnt create a config file and it doesnt work.

@cnaude

OH.... Never mind found out what the problem was... As I was copying the logs I saw something about the chairs... and it said there was a dependency... completely missed that.... x.x hate it when I do that..... Sorry.

So, I download 2.0.2 jar Put it in plugins folder reload server typed /plugins, its not listed checked server, don't see any loading on the logs... stopped server, and ran it again, still nothing, no chairs folder is created.... what did I do wrong??? D: I really want this plugin but its not working for me....

my craftbukkit version is 1.5.1 as to exact version.... just what ever is http://forums.bukkit.org/threads/craftbukkit-1-5-1-r0-1-is-now-available.139229/ on this post....