TM 1.3 errors and design suggestions #4


  • Bug
Open
  • SpigotSlimeDog created this issue Dec 19, 2016

    A few bugs and design issues:

    • An answer automatically closes its ticket. Comment and close should  be separate events. (The requested dependent table should be event, rather than comment, as I suggested in an earlier note. The event table should record various events. Comment and close are types of event.)
    • When you implement the event table, new events should reopen the ticket. There should be explicit close and reopen commands.
    • Open and answer text generate java exceptions if they contain single quotes. I assume that single quotes are used to delimit SQL text statements. The TM parser should detect single quotes and construct the appropriate SQL, so that "It's OK" becomes "It''s OK" went submitted to the SQL engine. (Double quotes are included in the text recorded in the database.)
    • Errors (such as single quotes) are not reported to the player, so they do not know that a event has not posted, unless they check explicitly with view.
    • Records in all tables should be timestamped. This will be even more important when you implement the event table. We need to know when events transpired.
    • Please support commands from the console.
  • SpigotSlimeDog added a tag Bug Dec 19, 2016
  • SpigotSlimeDog edited description Dec 19, 2016
  • SpigotSlimeDog edited description Dec 19, 2016
  • HootHootmen posted a comment Dec 20, 2016

    First of all: thanks for the feedback: however, a quick, and fair, warning: V1 is a Continuation of an already (but dead) plugin named TicketMan.

    Most of the shortcomings in this version is due to that version.

    1. In Version 2.0 (which will also come with a Database Converter to convert current data into the new data) a Ticket will have 1 body ticket, several reply (up till however many queries SQLite can hold for example) tickets, and 1 solution ticket.
      It would look something like this
      Tickets_data, Tickets_Answers and Ticket_Notes
      Ticket Data will hold the initial data and if the ticket is open yes or no.
      Ticket Answer will contain all back and forth communication between the player and the administrator. Once a Ticket has been resolved, /ticket mark <id> <answer> will implement the answer and mark the answer as the solution ticket in the Ticket Database.
      Ticket Notes will contain All notes administrators made on the ticket (for example when investigating issues). These are Administrative only.
    2. I know this, and I have been looking into resolving this... But for that I need to recode the whole Ticketing system.. Hence forth I am going to say: Wait for V2, should be out in about a week or 2.
    3. I can make a quickpatch for that, but I cannot do this today (Work, Work).
    4. I'll implement a way to store the Special Markers in the database.
    5. Console Support is planned, and ill see IF i can implement it in this current version. That being said, I cannot promise a thing, as the code of V1 is a bit.. Hecktic

     


    Edited Dec 20, 2016
  • SpigotSlimeDog posted a comment Dec 20, 2016

    Thanks for the quick response. All good. I was not suggesting that it should all be done today, just want to help guide in the right direction. I was a support manager for several years in my checkered career, so have opinions about the nature of support systems. Good fortune moving forward, and I look forward to the results.


    Edited Dec 20, 2016
  • HootHootmen posted a comment Dec 20, 2016

    I am busy making a dedicated forum for Ticket Manager, as Ticket Manager will be MUCH more than just Tickets. But.. A things that are planned are going to be a surprise.


    Edited Dec 20, 2016
  • HootHootmen posted a comment Dec 20, 2016

    Also; The main things I am currently more concerned is:

    Changing bad code like:

    sql.query("insert into tickets values(NULL, 'open', '"+player+"', '"+escaped+"', '"+" "+"', '"+LocalServer+"', '"+world+"', '"+x+"', '"+y+"', '"+z+"');");

    to

    sql.prepare("insert into tickets value(NULL, 'open', ?, ?, '"+" "+"', ?, ?, ?, ?, ?)");

     

    For security purposes ofc..


    Edited Dec 20, 2016
  • SpigotSlimeDog posted a comment Dec 20, 2016

    Yep.


    Edited Dec 20, 2016
  • HootHootmen posted a comment Jan 13, 2017

    Just to update on the progress: V2 is about 50% done, and I am going work next week all week on it. So I hope to have V2 released at the end of next week (ofc it will be a beta release, WITHOUT any web GUI at this moment)


    Edited Jan 13, 2017
  • SpigotSlimeDog posted a comment Jan 13, 2017

    Excellent. Thanks for heads-up. I will evaluate when posted.


    Edited Jan 13, 2017
  • SpigotSlimeDog posted a comment Mar 7, 2017

    How is progress on V2? Looking forward to it.

  • SpigotSlimeDog posted a comment Mar 19, 2017

    Just a reminder: End of next week was two months ago. Looking forward to v2.0-beta.


    Edited Jul 7, 2017
  • SpigotSlimeDog posted a comment Jul 7, 2017

    Just a reminder: End of next week was six months ago. Looking forward to v2.0-beta.

  • HootHootmen posted a comment Feb 25, 2019

    Greetings, my sincerest apologies for the SEVERELY late response: Real Life kicked in, and kicked my butt. 

    Updating to accommodate the latest updates, and then reworking on V2. 

     

  • SpigotSlimeDog posted a comment Feb 25, 2019

    Welcome back.


To post a comment, please login or register a new account.