Bukkit

@Bodyash

They should get teleported back every 10 second nevertheless though.
However, I will try to prevent shopkeepers from entering vehicles in the next version. Thanks!

@boushwa

Nope there is nothing like this available currently. Just curious: How would you expect setting this up for a shopkeeper? Would a command that sets a limit of number of trades (optionally with a specific time) for the shopkeeper be sufficient for something like this? Something like '/shopkeeper maxTrades 10 24' to limit the amount of trades the shopkeeper accepts in 24 hours to 10.

@MasterMithrandir

You could turn on debug mode any see what it prints to the log when you try those trades again. Shopkeepers will prevent some types of 'special' clicks, because there are either duplication issues possible or the plugin wouldn't be able to reliable determine how many items were actually traded.
So if it says in the log 'Prevented special click in trading window' then try again with pure single left clicks, and also make sure that no client mods are running.

Quote:

Also I noticed this misspelled on config: "msg-trade-term-removed", maybe you mean "perm"?

The message in the default config will be fixed in the next update, thanks!

I am currently also thinking whether or not I should change the new permission node 'shopkeeper.setTradePerm' to 'shopkeeper.settradeperm': all lower-case, to match the other permission nodes.. Can't make a clear mind on that yet though.

@shaliquinn

Are you running the latest version of shopkeepers?
There were issues with heads in the past which could cause your save file to get wiped due to a bukkit bug. However, I have made some changes in the meantime so that it would not clear your complete save file but only the affected trade in case it runs into this issue. And also spigot made some changes as well to (partly) fix the above issue (so that it should at least no longer trigger any error).

So if you still have issues, please create a ticket, and attach your server log including any errors. And also describe how you create those player heads items (ex. which plugin/command/etc. you use for creating them).

@Snorpenbass73

Please create a ticket and attach your server log there, including those errors.

@CrsAurelio

Shopkeepers isn't handling the spawning of the citizens npc shopkeepers. Are other citizen npcs behaving the same way? You could try running '/citizens save': Some time ago I noticed that the npcs didn't seem to persist without running that command.

v1.71 for MC 1.9.x, 1.8.x, 1.7.10

This update contains a few changes, which might require you to update/reset your config and language file.

• In MC 1.9 all spawn-eggs use the data value 0 now. The default shop creation item data value was changed to 0 for now. This will cause all spawn-eggs to function as shop creation item by default. There is no new option yet to limit the shop creation item to the villager egg.
• Replaced 'disable-living-shops' with 'enabled-living-shops'. You might have to update your config due to this, however it has the advantage that whenever new mob types, which are disabled by default, are added to shopkeepers in the future, they don't automatically get enabled on servers which already run shopkeepers (which already have an old config which doesn't list those new mob types as disabled yet).
• Did some internal refactoring, mostly related to living shop types: Shopkeepers is now automatically 'supporting' all living entity types available for your server version for being used as shop entities. However, not all entity types will properly work: If you want to try out on your own risk if a living entity type works as shop entity, you will have to manually enable it in the config.
• Added RABBIT to the by default enabled living shop entity types.
• Slightly changed the default shopkeeper list entry message, to display the shopkeeper's session id instead of the list index. Also the colors where slightly changed to make it better readable.
• Added some german translations for some command argument names to the included default german translation.
• Added setTradePerm command: This allows setting of a custom permission for individual admin shopkeepers, which is then required for being allowed to trade with the affected shopkeeper. Also added a few new messages related to this.
• Also added a new message which gets sent to players which don't have the regular trade-permission. By default the message text is the same as the message being sent if the player is missing the newly added custom trading permission, though those can be changed in the config independently.
• The 'remote' command now also accepts a shop's unique id or session id (instead of the shop name).
• The default 'unknown-shopkeeper'-message was changed to include the 'unknown id' fact.
• No longer manually saving item attributes for servers running on MC 1.9 upwards. Since somewhere in late 1.8 bukkit started saving attribute data as part of their 'internal' data. Attribute loading is left in for now, in case someone updates from a bukkit version which didn't save attributes yet. This should also fix the issue of the new Slot attribute added in MC 1.9 being now properly saved.
• Slightly changed the saving procedure which will hopefully make it less likely that all your save data gets lost if something goes wrong during saving: The data gets now first saved to a different, temporary file (in the shopkeepers plugin folder). Only if saving was successful, the old save file gets removed and replaced by the new one. Also added a bit more debugging information to the related messages.
• Added a possible workaround for the 'duplicating villagers' issue some people still seem to have sometimes:
  My current guess on the problem is, that: The shopkeeper entities get saved to disk when the world gets saved. Shopkeepers removes a shop entity, respawns the entity (this replaces the old 'last-entity-uuid'). This does not necessarily have to happen at the same time or for all entities, but it does occur when shopkeepers is for ex. getting reloaded. Now if the server closes (ex. due to a crash) without another world save taking place, the old shop entity is still saved in the chunk data of the world, but we cannot identify it as shop entity on the next server start, because we remembered the entity-uuid of the last entity we spawned, which is not the same as the last entity which was saved to disk.
  This workaround: Whenever the world gets saved (at least whenever WorldSaveEvent gets triggered) all shopkeepers get temporarily unloaded (and by that removed from the world) and loaded (respawned) again shortly after the world-save. With this the shop entities will hopefully no longer get stored to the chunk data. You will notice a short flicker of shop entities, but trading etc. should keep working, even during world-saves. If you have debug-mode enabled in the config, you will get a rather large block of debugging output everytime all your worlds get saved.

@PAINmatrix

There is a setting for that in the config.

@FreddyGB

Can you send me that timings report? Also, how large is your save.yml file.
Also, how much memory do you use, what are your server's xms and xmx start parameters?
And how do you meassure the memory usage of shopkeepers? How you you make the conclusion that shopkeepers is having a memory leak (and not something else on your server)? The timings reports don't include any memory profiling information as far as I am aware.

As I have no problems with shopkeepers running on my own server, I need further information to look into.
If you have further information for me, then please create a ticket for this and attach that information there.