Bukkit

In reply to kain_mercer:

 There is a pro con list between the two. 

Pros for the old one:

Its faster. Much faster

Pros for the new one:

It can detect a unlimited amount of blocks as it doesnt attempt to detect everything at once. 

The cons are the vice versa. Such as the new one is much slower

In reply to kain_mercer:

I dont have a computer infront of me so i can not give the exact however the suggestions (shown on the players screen or by hitting tab on the console) will show the suggestions. 

/Ships config set config Advanced.Block.Finder block_finder_ships_six

The part i am unsure about is the last two arguments, the Advanced.Block.Finder is the key argument, i am 90% sure its that (100% something like that) and the next argument is the value, there should be 2 options in the suggedtions, one ending in ships six and the other ending in ships five

In reply to kain_mercer:

 So I have just fixed the error in my dev build of Ships. I got it wrong, the issue comes from a complete different part of Ships. The issue stems from the progress bar not being shown. While progressbar is disabled in your config, there are some parts of the code that didnt get the message that it is and attempts to update a progress bar that isnt there.

The quick fix would be to enable the progress bar (minecraft calls it a bossbar so thats what it is called in the config)

Just uploaded Ships 6.0.0.0 R2 Alpha 2.3, ready to download.

In reply to kevinhsneh:

 Thanks for watching. Sorry you didnt understand the code but nice to know i kept you entertained. 

Grammar is not my forte, so you may see it get corrected every so often. On the live show I was mainly modifing the new command system that would make it a lot more simple for me to add command, it would also gain access to more peemissions with the commands. 

As for the current version almost not matching the old file. I have done a lot of work on the new movement and block tracking algorithms that has greatly improved stability. 

I am aware of a few issues with them though and plan to mitigate the issues as soon as possible. Current issues I know about that are new to 2.3 are the following:

The new fast loader may crash ships due to async activity

EOT ignores if the ship has done moving and attempts to move the ship even before it is done resulting in a ship you can not stop. 

I am also aware that the new tracking algorithm takes a while to track, i have some ideas for optimizations but it means rewriting a small part of Ships, so stay tuned. 

In reply to kevinhsneh:

 So the issue you arr refering to is the async quick loading. I have fixed it on my internal server and will be releasing it soon. 

Basically whats happening is minecraft itself doesnt like it when you interact with the world on a separate thread. Due to the fact that loading the structure of the ship i thought won't interact with the world as its loading 3dVectors (XYZ) i put the code for loading the structure on a separate thread. However the issue is that if the structure loaded has any slight hickup and ships quickly attempts to fix the issue, one of the issues is it not knowing where the licence sign is compared to the structure, so it checks where the sign is out of the structure to resync it, this being a interaction with the world. 

The fix I have done is taken them off the second thread and back on the main thread, loads slower but way more reliable

In reply to kevinhsneh:

 Thanks for the report. Ill be able to test it soon and see what I can do

In reply to kevinhsneh:

 The submarine altitude issue is fixed in Alpha 2.2. It should also have fixed the deformation of the sea 

In reply to bradyykennyy:

 As for more compatibility. As you may have seen im still working towards a stable build of Ships 6.0.0.0 however after that I plan to update all the first party addons to Ships with some exceptions (some of the plugins ships added onto didnt make the jump to 1.13+).

As for the tps drop, there is, as long as your using Ships 6. The short answer is to change the values in the config for Movement Algorithm and Block Detection from Ships 5 to Ships 6. You can do this using the /ships config command. 

The long answer is, the tps is dropping due to the amount of steps required to be done in a single tick of the server. The ship needs to be detected, updated structure and then moved all in a single tick. Minecraft hates when you attempt to do what any other game does which is to use more Threads (a thread is a section of code that is ran, and depending on the processor your server is running on, can mean that multiple sections of code can be ran at once). The Ships 6 block detection and movement algorithm do all the same steps, however do it over multiple ticks, giving the server time to breathe. This does mean that the moving of the ship is slower but it reduces the lag so much that in my testing I didnt have any tps drop. 

In reply to bradyykennyy:

The config command will change the config value without needing to go into the config itself. So it should be in effect, you can test using the /ships config view config command. 

Based on what you have said so far. It seems you havent changed the movement algorithm (the movement algorithm makes the largest change to tps). 

As for the tracking limit (default value being 4000) this is the limit that the block finder algorithm will give up trying to find more blocks. With Ships 5 block finder it can be used lower tps by lowering the value, with the ships 6 block finder it is used to speed up the movement of ships by lowering

In reply to bradyykennyy:

 If you are able to change the block finder then you are able to change the movement algorithm, type the following command in exactly to change the movement algorithm. 

ships config set config Advanced.Block.Movement ships:movement_ships_six