Case insensitivity for offline users #447


  • New
  • Enhancment
Open
Assigned to _ForgeUser1255850
  • _ForgeUser8494594 created this issue Mar 31, 2013

    Using the admin commands grantxp, removexp, promote, demote, employ, fire, and transfer do not work as expected from server console. When performing the command from the console, the player in game receives the correct message, but checking with /jobs stats does not show the changes. Changes are not present after a player relog, nor are they after a server restart. It just shows the confirmation messages but doesn't actually make the changes.

    Spigot-b617
    Jobs-v2.9.1


    - EDIT -
    After some additional testing i found the apparent issue... which actually has nothing to do with what's i initially reported...
    It has to do with player names and case sensitivity. The admin commands do indeed work from the console. The issue is that player names are case sensitive in the jobs plugin. This may cause issues when using the admin commands with automated ranking systems or other scenarios.

    Now, i agree that player names should be case sensitive. The thing that you should be aware of from all my ramblings can be exemplified in an example:

    Player A = john
    Player B - John

    /jobs employ john miner
    

    Both John and john get confirmation messages
    Only john gets employed

  • _ForgeUser8494594 added the tags New Enhancment Mar 31, 2013
  • _ForgeUser8494594 edited description Mar 31, 2013
  • _ForgeUser1255850 posted a comment Apr 1, 2013

    Honestly names shouldn't be case sensitive, since Minecraft usernames are case insensitive, even though there is only one correct "case". Half of it is a problem with the way the database was designed by flametornado back in the day (it's essentially broken by design), however, it requires a lot of work and hacks to workaround. If I get around to fixing the database this sort of issue will go away. The database really needs a rewrite, I haven't touched it since I took the project over years ago.

    Once I get around to redoing the entire database these sorts of issues should go away.

  • _ForgeUser8494594 posted a comment Apr 1, 2013

    @phrstbrn: Go

    Alrighty sir. I figured i'd let you know what i found. Feel free to remove the ticket and make a new more concise one for your todo list if you see fit :) Whether player names are case sensitive or not doesn't really matter to me tbh so long as all plugins use the same standard. I wonder why bukkit doesn't regulate that in their approval process? Meh w/e... cheers sir :)


To post a comment, please login or register a new account.