Separate global files #408


  • New
  • Enhancment
Open
  • _ForgeUser6836232 created this issue Sep 1, 2012

    The Issue: I have six worlds on my servers, and each has unique permissions to that world. Problem is when we promote new players, the plugin has to make changes to six large users.yml files which causes a 1-2 second "hiccup" where the server just "pauses." This is even worse if we promote one player and then another one right away.

    I've tried looking at my permissions today, to try and consolidate permissions files so some worlds can be just mirrored, but that would mean a lot of flexibility would be lost.

    Possible solution: Instead of having global files for both groups and user .yml, files let admins pick.

    So in the config instead of:
    use-global-files: false

    Have something like:
    use-global-user-files: true
    use-global-group-files: false

    This way each world can still have it's own unique permissions, but all of the users will be looked up/located in one global file, instead of multiple ones like it is now.

    I believe this would be extremely beneficial to those with many worlds that are possibly facing the same issue.

    Thank you!

  • _ForgeUser6836232 added the tags Enhancment New Sep 1, 2012
  • codename_B posted a comment Sep 2, 2012

    Alternatively, I can improve the math for permissions recalculation ;)

  • _ForgeUser6836232 posted a comment Sep 2, 2012

    Well, I've had this issue for a long time now, and our user.yml files are only getting larger and larger. This would make it six times faster (in my case) right away.

    I also think in most cases admin only need one user.yml file anyway, since those are usually the same for every single world unlike group.yml files.

    I really don't know how hard it would be to implement, as I really have no knowledge of programming at all, but if you need me to test anything either way, I would be happy to do so.

    Also, thank you for the quick reply.

  • codename_B posted a comment Sep 2, 2012

    @imaxorz: Go

    You can run /permissions cleanup to clean up the "old" users in the users.yml :)

  • _ForgeUser6836232 posted a comment Sep 2, 2012

    Ahhhhh, I feel silly now...

    Let's see how it goes.


    Edited Sep 2, 2012
  • _ForgeUser6836232 posted a comment Sep 2, 2012

    Well that helped a bit I guess. Files went from 700+KiB to about 400+KiB

    Hope you still maybe consider what I suggested down the road :)

    Thanks for all the great work!


    Edited Sep 2, 2012
  • _ForgeUser6836232 posted a comment Sep 2, 2012

    This is after running the cleanup command:

    http://www.youtube.com/watch?v=YV96wdSBTII

  • codename_B posted a comment Sep 6, 2012

    I'm working on finding a faster YAML lib.

  • _ForgeUser6836232 posted a comment Sep 25, 2012

    After your improvement tweaks it helped a bit, but I still get TPS drops when promoting players :/

    Maybe you can re-consider this? I would gladly buy you a few pizzas.


To post a comment, please login or register a new account.