Bukkit

Reposting this in from the comment I left on the bukkitdev page.

There are 2 HUGE bugs that need your attention. I am filling out a ticket also, but if these don't grab your attention, I don't know what will. I'm not trying to be "that guy" because I really do enjoy the plugin. However there are 2 huge server breaking things that are happening with this plugin.

I am using Spigot 1.8.7, and our economy system is Essentials.

1. At random, during a server restart, a person's shop will be completely wiped. This doesn't happen to every single person, but I have had multiple complaints of this happening, and there are no steps that I can list to replicate. It seems to choose a victim at random. The only thing I can 100% confirm is that this is happening on a server restart.

2. A person can use this system to duplicate items. Steps to replicate include placing a chest, placing the items you want to duplicate into the chest, then placing the shop sign on top. Name the shop, open the shop, then break the shop sign. Items will then duplicate, and could proceed to be sold at the server shop, etc. I have confirmed this myself and it works 100% of the time.

With Issue #1. Errors such as the following have appeared:

[Craft Scheduler Thread - 131/WARN]: Exception in thread "Craft Scheduler Thread - 131"
[10:16:20] [Craft Scheduler Thread - 131/WARN]: org.apache.commons.lang.UnhandledException: Plugin BetterShops v2.1.2 generated an exception while executing task 2947
    at org.bukkit.craftbukkit.v1_8_R3.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:56)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
    at java.lang.Thread.run(Unknown Source)
Caused by: java.lang.NullPointerException
    at max.hubbard.bettershops.Listeners.CreateShop$1.run(CreateShop.java:169)
    at org.bukkit.craftbukkit.v1_8_R3.scheduler.CraftTask.run(CraftTask.java:71)
    at org.bukkit.craftbukkit.v1_8_R3.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:53)
    ... 3 more

[10:16:21]

I wanted to add a comment that I have found an additional exploit:

When I set up admin shops for the server, and allowed the shop to be able to accept cobblestone from users for money, the shop never takes the cobblestone, allowing users to make infinite amounts of money. I am not aware of any additional items having this issue, but it's worth double checking.

Again, I am a big fan of this plugin and it has serious potential. I hope you can address these concerns. If so, I'm open to donating a few bucks your way for your efforts if everything works as intended. Thanks man.

I'm having the same issue.. It must be considered as a critical one.